Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webdrivers gem to simplify local development #1810

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joehorsnell
Copy link

I noticed when doing an unrelated PR (#1809) that running the specs locally requires chromedriver.

Failures:

  1) Account user with Stripe Customer ID
     Failure/Error: visit root_path

     Selenium::WebDriver::Error::WebDriverError:
       Unable to find chromedriver. Please download the server from
       https://chromedriver.storage.googleapis.com/index.html and place it somewhere on your PATH.
       More info at https://github.com/SeleniumHQ/selenium/wiki/ChromeDriver.
     # ./spec/support/helpers/authentication_helper.rb:10:in `sign_in_as'
     # ./spec/features/account_spec.rb:17:in `block (2 levels) in <top (required)>'
     # ./spec/support/background_jobs.rb:4:in `block (3 levels) in <top (required)>'
     # ./spec/support/background_jobs.rb:22:in `block in run_background_jobs_immediately'
     # ./spec/support/background_jobs.rb:21:in `run_background_jobs_immediately'
     # ./spec/support/background_jobs.rb:3:in `block (2 levels) in <top (required)>'

This PR simplifies local development by using webdrivers to automatically download the correct
version of chromedriver.

I noticed when doing an unrelated PR (houndci#1809) that running the specs locally requires `chromedriver`.

```
Failures:

  1) Account user with Stripe Customer ID
     Failure/Error: visit root_path

     Selenium::WebDriver::Error::WebDriverError:
       Unable to find chromedriver. Please download the server from
       https://chromedriver.storage.googleapis.com/index.html and place it somewhere on your PATH.
       More info at https://github.com/SeleniumHQ/selenium/wiki/ChromeDriver.
     # ./spec/support/helpers/authentication_helper.rb:10:in `sign_in_as'
     # ./spec/features/account_spec.rb:17:in `block (2 levels) in <top (required)>'
     # ./spec/support/background_jobs.rb:4:in `block (3 levels) in <top (required)>'
     # ./spec/support/background_jobs.rb:22:in `block in run_background_jobs_immediately'
     # ./spec/support/background_jobs.rb:21:in `run_background_jobs_immediately'
     # ./spec/support/background_jobs.rb:3:in `block (2 levels) in <top (required)>'
```

This PR simplifies local development by using [webdrivers][1] to automatically download the correct
version of `chromedriver`.

[1]: https://github.com/titusfortner/webdrivers
@joehorsnell joehorsnell force-pushed the use_webdrivers_gem_to_simplify_local_development branch from 83c86b8 to c01268d Compare August 6, 2020 08:49
@joehorsnell
Copy link
Author

Not sure who is monitoring PRs in this repo, but @gylaz, you reviewed another PR I opened, so are you able to review this one too? Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants