Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification's emails HTML alternative + subject translation #170

Merged
merged 2 commits into from
Sep 21, 2016

Conversation

DylannCordel
Copy link
Contributor

Related to #167

  • Emails are now sent in text + an HTML alternative (two templates available). Test added.
  • Email's subject was outside the "for loop" with user's locale activation and emails was sent with last post author locale. Correction and tests added.

pass

try:
send_mass_html_mail
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean send_html_mail here? AFAICT the mass one will always trigger the exception as it's not imported/defined anywhere before.

@zopieux
Copy link

zopieux commented Jun 13, 2015

Don't forget to wrap text within {% autoescape off %} in all the plain-text mail templates. If you don't, the user Belieber<3 will be rendered as Belieber&lt;3 in the mail client.

@DylannCordel DylannCordel force-pushed the features/html_notifications branch 2 times, most recently from 572c03f to f5f509c Compare June 14, 2015 17:54
@DylannCordel
Copy link
Contributor Author

Thanks for your feedback @zopieux
For the try/except, I removed it : if user set pybb to use mailer but that this one can not be imported, IMHO it's better to not intercept the exception.

@DylannCordel
Copy link
Contributor Author

@GeyseR : could you restart the travis buid please ? It failed becauseof a network bug from travis and/or github. Thx !

@DylannCordel
Copy link
Contributor Author

rebased with master

@DylannCordel
Copy link
Contributor Author

up...

@lampslave lampslave merged commit 1500c98 into hovel:master Sep 21, 2016
@DylannCordel DylannCordel deleted the features/html_notifications branch January 2, 2017 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants