Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDIOMS Update & BULKI v0.1 #203

Merged
merged 883 commits into from
Sep 10, 2024
Merged

IDIOMS Update & BULKI v0.1 #203

merged 883 commits into from
Sep 10, 2024

Conversation

zhangwei217245
Copy link
Collaborator

@zhangwei217245 zhangwei217245 commented Jun 24, 2024

Related Issues / Pull Requests

Direct
#151 #169 #206

Indirect
#109 #132

Description

Major changes:

  • IDIOMS -> affix-based query benchmark
  • IDIOMS -> index persistence mechanism
  • IDIOMS -> numeric value query support (exact query and range query)
  • IDIOMS -> numeric value query benchmark
  • IDIOMS -> simulation test
  • BULKI V0.1 -> a data serialization and deserialization mechanism
  • Metadata JSON validator
  • Metadata JSON Loader for PDC

Minor changes

  • Updated Dockerfile for faster docker image build
  • Updated pdc_generic.h for full data type support capability and better ordering of PDC data type enums

In-progress changes

  • Some code for multi-condition query.

What changes are proposed in this pull request?

  • Bug fix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected; for instance, examples in this repository must be updated too)
  • [ x ] This change requires a documentation update

Checklist:

  • My code modifies existing public API, or introduces new public API, and I updated or wrote docstrings
  • [ x ] I have commented my code
  • My code requires documentation updates, and I have made corresponding changes to the documentation
  • [ x ] I have added tests that prove my fix is effective or that my feature works
  • [ x ] New and existing unit tests pass locally with my changes

src/tests/CMakeLists.txt Outdated Show resolved Hide resolved
@houjun
Copy link
Member

houjun commented Sep 5, 2024

@jeanbez @zhangwei217245, any idea why the clang-format fix is not triggered and the clang-format check keeps failing?

It seems like a python package issue for the clang-format plugin...

image

@houjun
Copy link
Member

houjun commented Sep 5, 2024

@zhangwei217245, some parallel tests on Permlutter CI are failing, see the logs

  Start 139: idioms_ci_mpi
     24/24 Test #139: idioms_ci_mpi ....................***Failed    7.79 sec
     96% tests passed, 1 tests failed out of 24

Copy link
Member

@jeanbez jeanbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the src/api/test_bulki.bin file unless there is a need for it to be there.

@zhangwei217245
Copy link
Collaborator Author

@zhangwei217245, some parallel tests on Permlutter CI are failing, see the logs

  Start 139: idioms_ci_mpi
     24/24 Test #139: idioms_ci_mpi ....................***Failed    7.79 sec
     96% tests passed, 1 tests failed out of 24

There should not be parallel test case for now. I just removed it from CMake.

@zhangwei217245
Copy link
Collaborator Author

Please remove the src/api/test_bulki.bin file unless there is a need for it to be there.

Removed. Thank you for reminding.

@zhangwei217245
Copy link
Collaborator Author

Plus: I don't have access to software.nersc.gov

image

@zhangwei217245 zhangwei217245 changed the title Draft: IDIOMS Update & BULKI v0.1 IDIOMS Update & BULKI v0.1 Sep 6, 2024
@jeanbez jeanbez merged commit 2e5de75 into hpc-io:develop Sep 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request type: new feature Request for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants