Sat sim tweaks2 #725
Merged
Sat sim tweaks2 #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keskitalo
force-pushed
the
sat-sim-tweaks2
branch
from
5977c2a
to
d3eebbf
Compare
keskitalo
force-pushed
the
sat-sim-tweaks2
branch
from
6391211
to
93339cd
Compare
tskisner
approved these changes
Mar 18, 2024
* Eventually, this could be moved to a dedicated operator which creates rotated boresight pointing. * For now, this is handled by the pointing_detector operator, and the rotated boresight is created if needed, and moved to the appropriate device.
keskitalo
force-pushed
the
sat-sim-tweaks2
branch
from
2004396
to
e7863bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapmaker was running out of memory after destriping had already completed. I arranged the code so that map domain data products are written and purged from memory as early as possible. I also purged template amplitude objects that were only used as intermediate containers during destriping.
In the process, it became painfully obvious that the
_exec()methods inMapMakerandSolveAmplitudeshad grown beyond readable lengths (~300 lines and ~900 lines) so I refactored them.I also added support for different coordinate systems in satellite simulation and detector pointing operators. The latter is more flexible but adds an extra quaternion multiplication every time detector pointing is expanded. These fixes address #565 and indirectly #80.
Some minor tweaks to the satellite simulation workflow:
sample_rateandthinfpoptions fromtoast_sim_ground.py