HPCC-32907 Improve roxie startup time by removing unused option

* The helper name has been computed for many years, but roxie still contained code to extract it from the graph if it was set. Signed-off-by: Gavin Halliday <[email protected]>
hpcc-systems · Oct 30, 2024 · 4735ff9 · 4735ff9
1 parent cf4b015
commit 4735ff9
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/roxie/ccd/ccdquery.cpp b/roxie/ccd/ccdquery.cpp
@@ -625,9 +625,7 @@ class CQueryFactory : implements IQueryFactory, implements IResourceContext, pub
             break;
         }
         StringBuffer helperName;
-        node.getProp("att[@name=\"helper\"]/@value", helperName);
-        if (!helperName.length())
-            helperName.append("fAc").append(id);
+        helperName.append("fAc").append(id);
         HelperFactory *helperFactory = dll->getFactory(helperName);
         if (!helperFactory)
             throw MakeStringException(ROXIE_INTERNAL_ERROR, "Internal error: helper function %s not exported", helperName.str());
@@ -2002,9 +2000,7 @@ class CAgentQueryFactory : public CQueryFactory
             else
             {
                 StringBuffer helperName;
-                node.getProp("att[@name=\"helper\"]/@value", helperName);
-                if (!helperName.length())
-                    helperName.append("fAc").append(node.getPropInt("@id", 0));
+                helperName.append("fAc").append(node.getPropInt("@id", 0));
                 HelperFactory *helperFactory = dll->getFactory(helperName.str());
                 if (!helperFactory)
                     throw MakeStringException(ROXIE_INTERNAL_ERROR, "Internal error: helper function %s not exported", helperName.str());