Skip to content

Commit

Permalink
HPCC-32922 Capture lookahead timings for join activities
Browse files Browse the repository at this point in the history
Signed-off-by: Shamser Ahmed <[email protected]>
  • Loading branch information
shamser committed Oct 31, 2024
1 parent 9d3734f commit 888ad90
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
6 changes: 4 additions & 2 deletions thorlcr/activities/join/thjoinslave.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,10 @@ class JoinSlaveActivity : public CSlaveActivity, implements ILookAheadStopNotify
{
try
{
startInput(secondaryInputIndex);

{
LookAheadTimer t(slaveTimerStats, timeActivities);
startInput(secondaryInputIndex);
}
if (ensureStartFTLookAhead(secondaryInputIndex))
{
IThorDataLink *secondaryInput = queryInput(secondaryInputIndex);
Expand Down
1 change: 1 addition & 0 deletions thorlcr/activities/keyedjoin/thkeyedjoinslave.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2662,6 +2662,7 @@ class CKeyedJoinSlave : public CSlaveActivity, implements IJoinProcessor, implem
}
void readAhead()
{
LookAheadTimer t(slaveTimerStats, timeActivities);
endOfInput = false;
CJoinGroup *groupStart = nullptr;
unsigned __int64 preFiltered = 0;
Expand Down
3 changes: 3 additions & 0 deletions thorlcr/activities/lookupjoin/thlookupjoinslave.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1447,6 +1447,7 @@ class CInMemJoinBase : public CSlaveActivity, public CAllOrLookupHelper<HELPER>,
IBitSet *queryRhsChannelStopSet() { dbgassertex(0 == queryJobChannelNumber()); return rhsChannelStop; }
void startLeftInput()
{
LookAheadTimer t(slaveTimerStats, timeActivities);
try
{
startInput(0);
Expand Down Expand Up @@ -1565,6 +1566,7 @@ class CInMemJoinBase : public CSlaveActivity, public CAllOrLookupHelper<HELPER>,
CAsyncCallStart asyncLeftStart(std::bind(&CInMemJoinBase::startLeftInput, this));
try
{
ActivityTimer s(slaveTimerStats, timeActivities);
startInput(1);
rhsStartedBefore = true;
}
Expand Down Expand Up @@ -2827,6 +2829,7 @@ class CLookupJoinActivityBase : public CInMemJoinBase<HTHELPER, IHThorHashJoinAr
}
virtual void start() override
{
ActivityTimer t(slaveTimerStats, timeActivities);
PARENT::start();
dbgassertex(isSmart() || (leftITDL->isGrouped() == grouped)); // std. lookup join expects these to match
}
Expand Down

0 comments on commit 888ad90

Please sign in to comment.