HPCC-32823 Add time waiting for git lock to the workunit stats

Signed-off-by: Gavin Halliday <[email protected]>
hpcc-systems · Oct 30, 2024 · bf6465c · bf6465c
1 parent cf4b015
commit bf6465c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/ecl/eclcc/eclcc.cpp b/ecl/eclcc/eclcc.cpp
@@ -1535,8 +1535,11 @@ void EclCC::processSingleQuery(const EclRepositoryManager & localRepositoryManag
 
             updateWorkunitStat(instance.wu, SSToperation, ">compile:>parse", StTimeElapsed, NULL, parseTimeNs);
             stat_type sourceDownloadTime = localRepositoryManager.getStatistic(StTimeElapsed);
+            stat_type sourceDownloadBlockedTime = localRepositoryManager.getStatistic(StTimeBlocked);
             if (sourceDownloadTime)
                 updateWorkunitStat(instance.wu, SSToperation, ">compile:>parse:>download", StTimeElapsed, NULL, sourceDownloadTime);
+            if (sourceDownloadBlockedTime)
+                updateWorkunitStat(instance.wu, SSToperation, ">compile:>parse:>download", StTimeBlocked, NULL, sourceDownloadBlockedTime);
 
             if (optExtraStats)
             {

diff --git a/ecl/hql/hqlrepository.cpp b/ecl/hql/hqlrepository.cpp
@@ -676,6 +676,8 @@ unsigned __int64 EclRepositoryManager::getStatistic(StatisticKind kind) const
     {
     case StTimeElapsed:
         return cycle_to_nanosec(gitDownloadCycles);
+    case StTimeBlocked:
+        return cycle_to_nanosec(gitDownloadBlockedCycles);
     }
     return 0;
 }
@@ -823,7 +825,12 @@ IEclSourceCollection * EclRepositoryManager::resolveGitCollection(const char * r
         throw makeStringExceptionV(99, "Unsupported repository link format '%s'", defaultUrl);
 
     bool alreadyExists = false;
+
+    CCycleTimer gitDownloadTimer;
     Owned<IInterface> gitUpdateLock(getGitUpdateLock(repoPath));
+    cycle_t blockedCycles = gitDownloadTimer.elapsedCycles();
+    gitDownloadBlockedCycles += blockedCycles;
+
     if (checkDirExists(repoPath))
     {
         if (options.cleanRepos)
@@ -853,7 +860,6 @@ IEclSourceCollection * EclRepositoryManager::resolveGitCollection(const char * r
 
     bool ok = false;
     Owned<IError> error;
-    CCycleTimer gitDownloadTimer;
     if (alreadyExists)
     {
         if (options.updateRepos)
@@ -890,7 +896,8 @@ IEclSourceCollection * EclRepositoryManager::resolveGitCollection(const char * r
     //this could become a read/write lock if that proved to be an issue.
     gitUpdateLock.clear();
 
-    gitDownloadCycles += gitDownloadTimer.elapsedCycles();
+    gitDownloadCycles += (gitDownloadTimer.elapsedCycles() - blockedCycles);
+
     if (error)
     {
         if (errorReceiver)

diff --git a/ecl/hql/hqlrepository.hpp b/ecl/hql/hqlrepository.hpp
@@ -105,6 +105,7 @@ class HQL_API EclRepositoryManager
     IArrayOf<IEclRepository> overrideSources;   // -D options
     IArrayOf<IEclRepository> allSources;        // also includes -D options
     cycle_t gitDownloadCycles = 0;
+    cycle_t gitDownloadBlockedCycles = 0;
 
     //Include all options in a nested struct to make it easy to ensure they are cloned
     struct {