Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-30890 Changelog automation to build-assets workflow #19219

Open
wants to merge 1 commit into
base: candidate-9.8.x
Choose a base branch
from

Conversation

Michael-Gardner
Copy link
Contributor

@Michael-Gardner Michael-Gardner commented Oct 21, 2024

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-30886

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@Michael-Gardner
Copy link
Contributor Author

@cloLN and @xwang2713 please give this a good look before I ping Gordon on it.

I tested all the logic with a standalone workflow on my own repository.

The output: https://github.com/Michael-Gardner/HPCC-Platform/releases/tag/community_9.10.0-rc1
Action run: https://github.com/Michael-Gardner/HPCC-Platform/actions/runs/11392119417

Copy link
Member

@xwang2713 xwang2713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload part looks good

@cloLN
Copy link
Contributor

cloLN commented Oct 21, 2024

Output files look good.

@Michael-Gardner Michael-Gardner changed the title HPCC-30886 Changelog automation to build-assets workflow HPCC-30890 Changelog automation to build-assets workflow Oct 21, 2024
@Michael-Gardner Michael-Gardner requested review from xwang2713 and removed request for cloLN and xwang2713 October 23, 2024 14:52
Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to relocate gfortil/PrettyGitLogs into hpcc-systems now or in the future?

- name: Checkout PrettyGitLogs
uses: actions/checkout@v4
with:
repository: gfortil/PrettyGitLogs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo should be relocated to hpccsystems (could open a Jira for this?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants