-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-32795 Additional optimizations to replaceString #19239
base: master
Are you sure you want to change the base?
Commits on Oct 25, 2024
-
HPCC-32795 Additional optimizations to replaceString
- Does nothing if no search string is supplied or if it is larger than the source string - Compare directly if search and source string are equal in length Signed-off-by: Jack Del Vecchio <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6f71021 - Browse repository at this point
Copy the full SHA 6f71021View commit details -
Directly copy newStr to buffer in special case.
- Add unit tests for special case
Configuration menu - View commit details
-
Copy full SHA for 4bb7a82 - Browse repository at this point
Copy the full SHA 4bb7a82View commit details
Commits on Oct 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 98315c6 - Browse repository at this point
Copy the full SHA 98315c6View commit details -
Optimize for case where no matches are found
- Add additional parameter to replaceString that returns whether a match was found - Wait to allocate memory until a match is made rather than at the beginning of the search - Avoid copying source into result if source wasn't changed
Configuration menu - View commit details
-
Copy full SHA for 19984dd - Browse repository at this point
Copy the full SHA 19984ddView commit details
Commits on Oct 29, 2024
-
Optimize for case where target is less than or equal to source string.
- Move the target into the source rather than copy and skip allocating. - Add tests for each case of target length
Configuration menu - View commit details
-
Copy full SHA for b6dc378 - Browse repository at this point
Copy the full SHA b6dc378View commit details
Commits on Oct 30, 2024
-
Change return type of replaceString function
- Returns a bool indicating whether a match was made - Accepts a parameter to force a copy even if no match was found
Configuration menu - View commit details
-
Copy full SHA for e3364e7 - Browse repository at this point
Copy the full SHA e3364e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b57c932 - Browse repository at this point
Copy the full SHA b57c932View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45800b0 - Browse repository at this point
Copy the full SHA 45800b0View commit details