Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32939 Coverity jsocket accept socklen issue #19267

Open
wants to merge 1 commit into
base: candidate-9.6.x
Choose a base branch
from
Open

HPCC-32939 Coverity jsocket accept socklen issue #19267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/jlib/jsocket.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,7 +1244,7 @@ ISocket* CSocket::accept(bool allowcancel, SocketEndpoint *peerEp)
}

DEFINE_SOCKADDR(peerSockAddr); // used if peerIp
socklen_t peerSockAddrLen = sizeof(peerSockAddr);
socklen_t peerSockAddrLen = sizeof(peerSockAddr.sa);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if peerSockAddrLen used below in getSockAddrEndpoint() is also helped with this change ?


T_SOCKET newsock;
for (;;) {
Expand Down
Loading