Code review

hpcc-systems · Aug 17, 2023 · 7f767fd · 7f767fd
1 parent 5f6efc0
commit 7f767fd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/.github/workflows/publish-release-on-merge.yml b/.github/workflows/publish-release-on-merge.yml
@@ -13,7 +13,6 @@ jobs:
           echo "Action     = ${{ github.action }}"
           echo "Event      = ${{ github.event_name }}"
           echo "Actor      = ${{ github.actor }}"
-          echo "Ref Name   = ${{ github.ref_name }}"
           echo "SHA        = ${{ github.sha }}"
 
       - uses: actions/checkout@v3
@@ -25,9 +24,10 @@ jobs:
           server-id: ossrh
           server-username: MAVEN_USERNAME
           server-password: MAVEN_PASSWORD
-          gpg-private-key: ${{ secrets.SIGNING_SECRET }}
+          gpg-private-key: MAVEN_GPG_KEY
           gpg-passphrase: MAVEN_GPG_PASSPHRASE
 
+      # Build & Publish steps are separated to isolate secrets from retry action code
       - name: Build package
         uses: nick-fields/retry@v2
         with:
@@ -42,3 +42,4 @@ jobs:
           MAVEN_USERNAME: ${{ secrets.OSSRH_USER_NAME }}
           MAVEN_PASSWORD: ${{ secrets.OSSRH_PASS }}
           MAVEN_GPG_PASSPHRASE: ${{ secrets.SIGN_MODULES_PASSPHRASE }}
+          MAVEN_GPG_KEY: ${{ secrets.SIGNING_SECRET }}
diff --git a/.github/workflows/publish-snapshots-on-merge.yml b/.github/workflows/publish-snapshots-on-merge.yml
@@ -14,7 +14,6 @@ jobs:
           echo "Action     = ${{ github.action }}"
           echo "Event      = ${{ github.event_name }}"
           echo "Actor      = ${{ github.actor }}"
-          echo "Ref Name   = ${{ github.ref_name }}"
           echo "SHA        = ${{ github.sha }}"
 
       - uses: actions/checkout@v3
@@ -27,8 +26,13 @@ jobs:
           server-username: MAVEN_USERNAME
           server-password: MAVEN_PASSWORD
 
+      - name: Conditional Debug
+        if: (!contains(github.ref_name, '-release'))
+        run: echo "Condition met"
+
+      # Build & Publish steps are separated to isolate secrets from retry action code
       - name: Build package
-        if: contains(github.ref_name, '-release') == false
+        if: (!contains(github.ref_name, '-release'))
         uses: nick-fields/retry@v2
         with:
           timeout_minutes: 15
@@ -37,8 +41,8 @@ jobs:
           command: mvn --batch-mode package -DskipTests -DskipITs --file DataAccess/pom.xml
 
       - name: Publish package
-        if: contains(github.ref_name, '-release') == false
-        run : mvn --batch-mode deploy -DskipTests -DskipITs --file DataAccess/pom.xml
+        if: (!contains(github.ref_name, '-release'))
+        run: mvn --batch-mode deploy -DskipTests -DskipITs --file DataAccess/pom.xml
         env:
           MAVEN_USERNAME: ${{ secrets.OSSRH_USER_NAME }}
           MAVEN_PASSWORD: ${{ secrets.OSSRH_PASS }}