HPCC4J-540 Missing file error during publish #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corrected error handling on prefetch thread to pass errors on startup - Fixed potential data race in exception handling - Added invalid signature test Signed-off-by: James McMullan [email protected]
|
@rpastrana please review |
rpastrana
reviewed
Sep 7, 2023
| @@ -294,6 +294,13 @@ public boolean hasNext() | |||
| try | |||
| { | |||
| rslt = this.binaryRecordReader.hasNext(); | |||
|
|
|||
| // Has next may not catch the prefetch exception if it occurs at the beginning of a read | |||
| // This is due to InputStream.hasNext() being allowed to through an IOException when closed. | |||
There was a problem hiding this comment.
Glad to see this comment, it's very helpful,
very minor: spelling in comment, should be throw
| @@ -1148,6 +1165,11 @@ public int available() throws IOException | |||
| // Do the check for closed first here to avoid data races | |||
| if (this.closed.get()) | |||
| { | |||
| if (this.prefetchException != null) | |||
| { | |||
| throw new IOException("", this.prefetchException); | |||
There was a problem hiding this comment.
is there any helpful info that should be added to this exception?
| // We are expecting a failure | ||
| if (readException != null) | ||
| { | ||
| System.out.println("Test passed with exception: " + readException.getMessage()); |
There was a problem hiding this comment.
Minor, but as worded, it could give the wrong impression that the test passed in spite of the exception. Perhaps: "Test passed with expected exception"
rpastrana
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James McMullan [email protected]
Type of change:
Checklist:
Testing: