HPCC4J-574 Jirabot improvements #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpastrana
reviewed
Feb 2, 2024
jpmcmu
changed the title
|
@rpastrana Implemented code review changes and rebased to 8.12.x |
rpastrana
approved these changes
Feb 8, 2024
| else: | ||
| transition = '' | ||
|
|
||
| if transition != '': |
There was a problem hiding this comment.
what happens if transition == '' ?
rpastrana
reviewed
Feb 9, 2024
| elif statusName == 'Closed': | ||
| transition = 'Reopen Issue' | ||
| else: | ||
| transition = '' |
There was a problem hiding this comment.
Let's log this else condition, something like "Unexpected Jira status encountered: statusName"
rpastrana
reviewed
Feb 21, 2024
| @@ -67,10 +68,17 @@ jobs: | |||
| transitions = jira.transitions(issue) | |||
| result += 'Error: Transition: "' + transition + '" failed with: "' + str(error) + '" Valid transitions=' + str(transitions) + '\n' | |||
|
|
|||
| if issue.fields.customfield_10010 is None: | |||
| issue.update(fields={'customfield_10010': pull_url}) | |||
| prFieldName = propertyMap.get('pullRequestFieldName', 'customfield_10010') | |||
There was a problem hiding this comment.
let's target the new jira name as a long term solution
- Moved github user dictionary to github action var - Changed logic for changing jira issue user - Added JirabotMerge to 8.12.x - Backported various Jirabot changes - Added Jira issue property map Signed-off-by: James McMullan [email protected]
|
@rpastrana Finished testing the issue property map change, looks good. Squashed and ready to merge if it still looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James McMullan [email protected]
Type of change:
Checklist:
Testing: