Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-562 Odd unsigned decimals incorrect scale #765

Merged
merged 1 commit into from
Oct 3, 2024
Merged

HPCC4J-562 Odd unsigned decimals incorrect scale #765

merged 1 commit into from
Oct 3, 2024

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Oct 1, 2024

  • Corrected BinaryRecordReader unsigned decimal parse code
  • Updated ECL test datasets to include odd precision decimal values

Signed-off-by: James McMullan [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@jpmcmu
HPCC4J-562 Odd unsigned decimals incorrect scale
0564372 
- Corrected BinaryRecordReader unsigned decimal parse code
- Updated ECL test datasets to include odd precision decimal values

Signed-off-by: James McMullan [email protected]
@jpmcmu jpmcmu requested a review from rpastrana October 1, 2024 01:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-562

Jirabot Action Result:
Workflow Transition To: Merge Pending
Additional PR: #765

rpastrana
rpastrana reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu looks reasonable.

rpastrana
rpastrana approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu approved. Will merge once you confirm this didn't add any github action failures.

@jpmcmu
Copy link
Contributor Author

jpmcmu commented Oct 3, 2024

@rpastrana The PR doesn't create any new failures. There was an unexpected failure in readResumeTest() but it appears to be intermittent and unrelated to this PR.

@rpastrana rpastrana merged commit 507fa42 into hpcc-systems:candidate-9.2.x Oct 3, 2024
6 of 7 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Jirabot Action Result:
Added fix version: 9.2.128
Added fix version: 9.4.102
Added fix version: 9.6.54
Added fix version: 9.8.28
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpastrana rpastrana rpastrana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcmu @rpastrana