BC-7239 - sonar 1

hpi-schul-cloud · Jun 21, 2024 · 5d444d4 · 5d444d4
1 parent 9dd94f5
commit 5d444d4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/main/java/de/svs/doido/mongo/ConfigmapApi.java b/src/main/java/de/svs/doido/mongo/ConfigmapApi.java
@@ -35,7 +35,7 @@ public void configmapsWrite(String namespace, String configmapName) {
         Configmap cfg = new Configmap();
         cfg.setName(configmapName);
         cfg.setUri("http://www.test.org");
-        if( !cfgWrite.writeConfigmap(namespace,configmapName,cfg) ) {
+        if( !cfgWrite.writeConfigmap(namespace,cfg) ) {
             throw new ForbiddenException();
         }
 

diff --git a/src/main/java/de/svs/doido/mongo/kubernetes/configmap/Write.java b/src/main/java/de/svs/doido/mongo/kubernetes/configmap/Write.java
@@ -17,7 +17,7 @@ public class Write {
     @Inject
     KubernetesClient client;
 
-    public boolean writeConfigmap(String namespace, String name, Configmap cfg) {
+    public boolean writeConfigmap(String namespace, Configmap cfg) {
         ConfigMap configmap = client.configMaps().inNamespace(namespace).withName(cfg.getName()).get();
         Map<String,String> labels;
         Map<String,String> data;
@@ -40,8 +40,8 @@ public boolean writeConfigmap(String namespace, String name, Configmap cfg) {
             }
         }
         else {
-            labels = new HashMap<String,String>();
-            data = new HashMap<String,String>();
+            labels = new HashMap<>();
+            data = new HashMap<>();
             labels.put("app.kubernetes.io/name", "doido-mongo");
             data.put("uri", cfg.getUri());
             configmap = new ConfigMapBuilder().withNewMetadata().withName(cfg.getName()).withNamespace(namespace).and().build();

diff --git a/src/test/java/de/svs/doido/mongo/ConfigmapApiTest.java b/src/test/java/de/svs/doido/mongo/ConfigmapApiTest.java
@@ -13,7 +13,6 @@
 import io.fabric8.kubernetes.api.model.Namespace;
 import io.fabric8.kubernetes.api.model.NamespaceBuilder;
 import io.fabric8.kubernetes.api.model.ConfigMap;
-import io.fabric8.kubernetes.api.model.ConfigMapList;
 import io.fabric8.kubernetes.api.model.ConfigMapBuilder;
 import io.fabric8.kubernetes.api.model.ObjectMeta;