perf(bettermarks_proxy): drop translations subdomain #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since translation files are now served from the `apps` domain directly. We are still seeing some low number of requests towards the translations domain, but we already deployed the the frontend that is no longer using it a week ago. Users affected by this will either not notice or just need to reload the page. https://bettermarks.atlassian.net/browse/OT-1
karfau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since translation files are now served from the
appsdomain directly.We are still seeing some low number of requests towards the translations domain, but we already deployed the the frontend that is no longer using it a week ago.
Users affected by this will either not notice or just need to reload the page.
Links to Tickets or other pull requests
https://bettermarks.atlassian.net/browse/OT-1
Changes
Drops the
translationssubdomain from the list of proxied subdomains.Datasecurity
Deployment
Bettermarks is going to shut down
translations.bettermarks.comin the evening of the 30th of September 2024.New Repos, NPM pakages or vendor scripts
None
Approval for review