browser: improve support for removing methods

hpi-swa-teaching · Dec 22, 2024 · 36987c1 · 36987c1
1 parent 04a4c49
commit 36987c1
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/removeMessage.st b/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/removeMessage.st
@@ -0,0 +1,6 @@
+actions
+removeMessage
+
+	^ super removeMessage
+		ifTrue: [contents := nil. self changed: #contents];
+		yourself
diff --git a/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/selectedMessage.st b/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/selectedMessage.st
@@ -7,4 +7,10 @@ selectedMessage
 		[^ self resultsForTestAndMessageSelection first valueStringOrText].
 	self selectedMessageName = #Definition ifTrue:
 		[^ self selectedClass "ifNotNil:" "#"definition].
-	^ super selectedMessage
+
+	^ super selectedMessage
+		ifEmpty:
+			[(self showingDecompile not and: [self selectedClassOrMetaClass notNil] and: [self selectedMessageName notNil]) ifTrue:
+				[self selectedClassOrMetaClass compiledMethodAt: self selectedMessageName ifAbsent:
+					[^ 'Missing']]];
+		yourself
diff --git a/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/setClass.selector..st b/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/setClass.selector..st
@@ -5,4 +5,8 @@ setClass: aBehavior selector: aSymbol
 		[contents := currentCompiledMethod := nil.
 		self decorateButtons.
 		^ self].
+	aBehavior compiledMethodAt: aSymbol ifAbsent:
+		[contents := currentCompiledMethod := nil.
+		self decorateButtons.
+		^ self].
 	^ super setClass: aBehavior selector: aSymbol
diff --git a/packages/SwaLintBrowser.package/SwaLintBrowser.class/methodProperties.json b/packages/SwaLintBrowser.package/SwaLintBrowser.class/methodProperties.json
@@ -71,6 +71,7 @@
 		"open" : "ct 12/12/2024 03:35",
 		"openChooseTarget" : "ct 12/12/2024 03:54",
 		"openWithTarget" : "ct 12/12/2024 03:59",
+		"removeMessage" : "ct 12/22/2024 02:26",
 		"results" : "ct 12/12/2024 06:12",
 		"results:" : "ct 12/17/2024 23:06",
 		"resultsForTestAndClassSelection" : "ct 12/17/2024 22:18",
@@ -90,12 +91,12 @@
 		"selectedClass" : "ct 12/17/2024 23:10",
 		"selectedClassIndex" : "ct 12/17/2024 23:11",
 		"selectedClassOrMetaClass" : "ct 12/18/2024 04:58",
-		"selectedMessage" : "ct 12/21/2024 20:51",
+		"selectedMessage" : "ct 12/22/2024 02:23",
 		"selectedMessageIndex" : "ct 12/18/2024 03:43",
 		"selectedMessageName" : "ct 12/17/2024 23:11",
 		"selectedTestNode" : "ct 12/18/2024 04:24",
 		"selectedTestNodePath" : "ct 12/18/2024 04:14",
-		"setClass:selector:" : "ct 12/19/2024 02:49",
+		"setClass:selector:" : "ct 12/22/2024 02:20",
 		"settingsMenu:" : "ct 12/19/2024 23:25",
 		"shiftedClassListMenu:" : "ct 12/13/2024 00:38",
 		"shiftedClassListMenuMore:" : "ct 12/13/2024 00:38",