Fix Harvest Moon not updating save metadata #19447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate solution for #18430, which helped #6078. Unfortunately the added check is not valid as it also prevents Harvest Moon from saving the in-game date properly to the savegame metadata.
Instead of checking the save type for whether to update the metadata, we just check if the data looks valid. There might be a better solution, but the various flags in
SceUtilitySavedataParam
likeoverwriteMode
don't seem to correlate much with the validity of the metadata in other games.@Kethen
Fixes #18687