Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IR interpreter: Replace the assert for downcount with a very predictable branch #19449

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

hrydgard
Copy link
Owner

Fixes breakpoints and other similar things, with a negligible penalty - the CPU branch predictor will just eliminate it in the common case.

…ble branch

Fixes breakpoints and other similar things, with a negligible penalty.
@hrydgard hrydgard added the IRInterpreter Occurs with IR Interpreter but not with another CPU backend. label Sep 11, 2024
@hrydgard hrydgard added this to the v1.18.0 milestone Sep 11, 2024
@hrydgard hrydgard merged commit 163af21 into master Sep 11, 2024
19 checks passed
@hrydgard hrydgard deleted the ir-interpreter-breakpoints branch September 11, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IRInterpreter Occurs with IR Interpreter but not with another CPU backend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant