Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to pay to amp invoices #1397

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

niteshbalusu11
Copy link
Collaborator

Signed-off-by: Nitesh Balusu [email protected]

This is just support for paying to AMP invoices, we can add support for receiving AMP in a seprate PR.

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blixt-wallet ❌ Failed (Inspect) May 8, 2024 3:41pm

src/state/Send.ts Outdated Show resolved Hide resolved
src/storage/database/transaction.ts Show resolved Hide resolved
src/state/Transaction.ts Show resolved Hide resolved
@@ -42,13 +53,26 @@ export const transaction: ITransactionModel = {
throw new Error("syncTransaction(): db not ready");
}

// Don't insert open transactions for AMP invoices
if (tx.status === "OPEN" && tx.ampInvoice) {
return;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may prevent us from creating our own AMP invoice inside Blixt.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why I did it this way but when we add create support we can fix this separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants