fixup! fixup! Generic Arrow Flight RPC data source with a Flight SQL …

…adapter

datafusion/core/src/datasource/flight/mod.rs

@@ -100,7 +100,7 @@ impl FlightTableFactory {
         &self,
         location: String,
         options: &HashMap<String, String>
-    ) -> datafusion_common::Result<Arc<dyn TableProvider>> {
+    ) -> datafusion_common::Result<FlightTable> {
         let channel = Channel::from_shared(location.clone())
             .unwrap()
             .connect()
@@ -111,10 +111,10 @@ impl FlightTableFactory {
             .metadata(channel, options)
             .await
             .map_err(|e| DataFusionError::External(Box::new(e)))?;
-        Ok(Arc::new(FlightTable {
+        Ok(FlightTable {
             metadata,
             origin: location,
-        }))
+        })
     }
 }
 
@@ -125,7 +125,8 @@ impl TableProviderFactory for FlightTableFactory {
         _state: &SessionState,
         cmd: &CreateExternalTable,
     ) -> datafusion_common::Result<Arc<dyn TableProvider>> {
-        self.open_table(cmd.location.to_owned(), &cmd.options).await
+        let table = self.open_table(cmd.location.to_owned(), &cmd.options).await?;
+        Ok(Arc::new(table))
     }
 }
 
@@ -186,7 +187,7 @@ impl TryFrom<FlightInfo> for FlightMetadata {
 }
 
 /// Table provider that wraps a specific flight from an Arrow Flight service
-struct FlightTable {
+pub struct FlightTable {
     metadata: FlightMetadata,
     origin: String,
 }