Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks and improve performance of ServletIo#requestBody #171

Open
wants to merge 10 commits into
base: series/0.23
Choose a base branch
from
Open

Benchmarks and improve performance of ServletIo#requestBody #171

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ca4b0cb
Benchmarks of reader vs requestBody
TimWSpence Jan 19, 2023
2c3970d
Don't use concurrently with single-element stream
TimWSpence Jan 23, 2023
7260d8d
Optimization: don't emit empty chunk
TimWSpence Jan 23, 2023
831675b
Minimize allocations
TimWSpence Jan 24, 2023
1179728
Suppress compiler warning
TimWSpence Jan 24, 2023
290eb5b
Fix compiler warning
TimWSpence Jan 24, 2023
9210893
Dispatcher per request in benchmark
rossabaker Jan 25, 2023
ffa5f3c
Bulk reads are more realistic
rossabaker Jan 25, 2023
20467d6
Not sure how I broke the workflow, but alright
rossabaker Jan 25, 2023
806fac7
Scalafmt
TimWSpence Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions benchmarks/src/main/scala/org/http4s/servlet/ServletIoBenchmarks.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,20 @@ class ServletIoBenchmarks {
readListener.onAllDataRead()
result
}

override def read(buf: Array[Byte]) = {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 I should have realized that the default is one byte at a time via Read

val result = in.read(buf)
if (in.available() == 0)
readListener.onAllDataRead()
result
}

override def read(buf: Array[Byte], off: Int, len: Int) = {
val result = in.read(buf, off, len)
if (in.available() == 0)
readListener.onAllDataRead()
result
}
}

case class HttpServletRequestStub(
Expand Down