Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Prometheus exporter. #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s-dwinter
Copy link

Add Prometheus exporter support.

Supports monitoring by Prometheus using globocom/tornado-prometheus exporter.

Monitoring is one of the essential elements to run in a product environment, so I think it is very useful to have it enabled by default.
Also, when running on Kubernetes, Prometheus monitoring is the most common.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2020

Codecov Report

Merging #166 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   94.06%   94.08%   +0.02%     
==========================================
  Files           6        8       +2     
  Lines         724      829     +105     
  Branches      120      141      +21     
==========================================
+ Hits          681      780      +99     
- Misses         29       34       +5     
- Partials       14       15       +1     
Impacted Files Coverage Δ
webssh/main.py 70.27% <100.00%> (+2.62%) ⬆️
webssh/handler.py 96.44% <0.00%> (-0.47%) ⬇️
webssh/utils.py 95.95% <0.00%> (ø)
webssh/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51d527f...ab9e7e6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants