Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish docker image #213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Publish docker image #213

wants to merge 1 commit into from

Conversation

Jamstah
Copy link

@Jamstah Jamstah commented Apr 9, 2021

Add a deploy stage to the travis build to publish a latest docker image to a registry for master and releases.

There seem to be a lot of webssh images on docker, it would be nice to have an official, regularly updated one to rely on..

If you agree that its a good idea, this PR would also require that you create a dockerhub account, and add the DOCKER_USERNAME and DOCKER_PASSWORD values to travis to be able to push the image.

Add a deploy stage to the travis build to publish a latest docker image to a registry for master and releases.
@codecov-io
Copy link

codecov-io commented Apr 9, 2021

Codecov Report

Merging #213 (41fe43b) into master (2f0d580) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   94.20%   94.08%   -0.13%     
==========================================
  Files           8        8              
  Lines         829      829              
  Branches      142      142              
==========================================
- Hits          781      780       -1     
  Misses         32       32              
- Partials       16       17       +1     
Impacted Files Coverage Δ
webssh/handler.py 96.67% <0.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f0d580...41fe43b. Read the comment docs.

@huashengdun
Copy link
Owner

I think it is a good idea to publish an "official" docker image for this app.
But is it too much to build and publish the docker image on every commit?
I would rather consider doing it on every release.

@Jamstah
Copy link
Author

Jamstah commented Apr 9, 2021

I would argue that having a bleeding edge latest isn't a bad thing, but I don't mind, its your project :)

Having latest track master also means you don't have to work out how to push the right latest image tag when you push a new release.

To stop it deploying latest, just remove that provider from the .travis. As there is other set up to do on the project (that I can't do because I'm not an admin), I'll leave that up to you. Happy to help out if needed.

@UlyssesZh
Copy link

I would rather consider doing it on every release.

I think it is possible to make latest point to the latest release while having master to be the bleeding edge latest? I know we can do this with gh action, but I don't know much about travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants