Cde design system #773
Cde design system #773
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c45e0f4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
🚀 Preview Deploy Report Updated✅ Successfully deployed preview here |
There was a problem hiding this comment.
Hi @edlu77, thank you so much for getting this started! It's looking good!
Some requests for this preview:
- I'm looking for updates in our design system to build this nav header:
- I created a list of design system updates for all nav headers on this issue to help organize what is needed in the design system first before implementing in the CDE: Use design system nav header #767
- Is it possible to get this to stick at the top of the page on scroll? This is functionality needed for all nav headers in the design system.
- I would like to see the updated HuBMAP apps sidenav implemented as well on click of the Apps icon button.
Thank you so much! Please don't hesitate to reach out if you have questions!
…into cde-design-system
apps/cde-ui/src/app/pages/landing-page/landing-page.component.theme.scss
Outdated
Show resolved
Hide resolved
...de-ui/src/app/pages/create-visualization-page/create-visualization-page.component.theme.scss
Outdated
Show resolved
Hide resolved
libs/cde-visualization/src/lib/components/histogram/histogram.component.html
Outdated
Show resolved
Hide resolved
libs/cde-visualization/src/lib/components/metadata/metadata.component.html
Outdated
Show resolved
Hide resolved
libs/cde-visualization/src/lib/components/violin/violin.component.html
Outdated
Show resolved
Hide resolved
|
Regarding the Software Status Indicator, this approved design articulates where we are at with our software. When an update is required, I can submit individual issues per application using it. We need 3 sizes for our various UIs. Let me know if you have any questions! Examples in approved UIsResourcesFTU Explorer nav header
App Library
|
…into cde-design-system
…into cde-design-system
| gap: 0.5rem; | ||
| border-radius: 1rem; | ||
| font: var(--sys-label-large); | ||
| // .upload-success { |
There was a problem hiding this comment.
Remove commented out code please
| } as File, | ||
| length: 1, | ||
| } as unknown as FileList; | ||
| // const mockFiles = { |
There was a problem hiding this comment.
Remove commented out code please
| @@ -21,29 +14,12 @@ describe('FileUploadComponent', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should load', async () => { | |||
There was a problem hiding this comment.
Why did you remove the tests for file loading?
…into cde-design-system
…into design-system-workflow-card
|
Added design system and updated styles for landing page, create vis page, and visualization page