-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cde design system #773
base: cde-mvp2
Are you sure you want to change the base?
Cde design system #773
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c45e0f4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
🚀 Preview Deploy Report Updated✅ Successfully deployed preview here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @edlu77, thank you so much for getting this started! It's looking good!
Some requests for this preview:
- I'm looking for updates in our design system to build this nav header:
- I created a list of design system updates for all nav headers on this issue to help organize what is needed in the design system first before implementing in the CDE: Use design system nav header #767
- Is it possible to get this to stick at the top of the page on scroll? This is functionality needed for all nav headers in the design system.
- I would like to see the updated HuBMAP apps sidenav implemented as well on click of the Apps icon button.
Thank you so much! Please don't hesitate to reach out if you have questions!
…into cde-design-system
apps/cde-ui/src/app/pages/landing-page/landing-page.component.theme.scss
Outdated
Show resolved
Hide resolved
...de-ui/src/app/pages/create-visualization-page/create-visualization-page.component.theme.scss
Outdated
Show resolved
Hide resolved
libs/cde-visualization/src/lib/components/histogram/histogram.component.html
Outdated
Show resolved
Hide resolved
libs/cde-visualization/src/lib/components/metadata/metadata.component.html
Outdated
Show resolved
Hide resolved
libs/cde-visualization/src/lib/components/violin/violin.component.html
Outdated
Show resolved
Hide resolved
…into cde-design-system
…into cde-design-system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup some commented out code
gap: 0.5rem; | ||
border-radius: 1rem; | ||
font: var(--sys-label-large); | ||
// .upload-success { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented out code please
} as File, | ||
length: 1, | ||
} as unknown as FileList; | ||
// const mockFiles = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented out code please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still seeing quite a bit of commented out code. Also please resolve merge conflicts
@@ -21,29 +14,12 @@ describe('FileUploadComponent', () => { | |||
}); | |||
}); | |||
|
|||
it('should load', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove the tests for file loading?
…into cde-design-system
…into design-system-workflow-card
Quality Gate passedIssues Measures |
Added design system and updated styles for landing page, create vis page, and visualization page