Consolidate ome-tiff-pyramid DAGs #146
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruffalo
force-pushed
the
mruffalo/consolidate-ome-tiff-pyramid-dags
branch
3 times, most recently
from
ea66203
to
b98698e
Compare
Currently disabled via a hardcoded assignment of `is_ims = False`, but I assume that flag can be implemented by examining the Airflow environment or something similar.
mruffalo
force-pushed
the
mruffalo/consolidate-ome-tiff-pyramid-dags
branch
from
b98698e
to
f39d25a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is close to working --
v1.3of theome-tiff-pyramidpipeline allows setting the downsampling type, and this allows consolidating the two variants of this DAG. I have no idea how to check whether the assay is IMS, so that is just left as a hardcodedis_ims = Falsein this draft PR.This should be ready for testing once the assignment of
is_imsis implemented.