Skip to content

Commit

Permalink
John conroy/last minute workspace updates (#3543)
Browse files Browse the repository at this point in the history
* Update max workspace resource options

* Update max ws time limit

* Add last modified to template

* Add changelog

* Remove dep

* Update changelog

* Update context/app/static/js/pages/Template/Template.tsx

Co-authored-by: Nikolay Akhmetov <[email protected]>

---------

Co-authored-by: John Conroy <[email protected]>
Co-authored-by: Nikolay Akhmetov <[email protected]>
  • Loading branch information
3 people authored Sep 18, 2024
1 parent 747e44b commit 8a7fffe
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG-last-minute-workspace-updates.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Increase maximum resource options for workspace jobs from 2 CPUs to 16, 32GB of memory to 128GB and session length from 6 hours to 12.
- Add last modified date to template detail pages.
6 changes: 3 additions & 3 deletions context/app/static/js/components/workspaces/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ export const DEFAULT_GPU_ENABLED = false;

/* Workspace resource limits */
export const MIN_NUM_CPUS = 1;
export const MAX_NUM_CPUS = 2;
export const MAX_NUM_CPUS = 16;

export const MIN_MEMORY_MB = 1024;
export const MAX_MEMORY_MB = 32768;
export const MAX_MEMORY_MB = 131072;

export const MIN_TIME_LIMIT_MINUTES = 60;
export const MAX_TIME_LIMIT_MINUTES = 360;
export const MAX_TIME_LIMIT_MINUTES = 720;
1 change: 1 addition & 0 deletions context/app/static/js/components/workspaces/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ interface TemplateTypes {
is_hidden: boolean;
job_types?: string[];
examples: TemplateExample[];
last_modified_unix_timestamp: number;
}

type TemplatesTypes = Record<string, TemplateTypes>;
Expand Down
9 changes: 9 additions & 0 deletions context/app/static/js/pages/Template/Template.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import AccordionDetails from '@mui/material/AccordionDetails';
import Typography from '@mui/material/Typography';
import AccordionSummary from '@mui/material/AccordionSummary';
import KeyboardArrowDownRoundedIcon from '@mui/icons-material/KeyboardArrowDownRounded';
import { format } from 'date-fns/format';

import { useWorkspaceTemplates } from 'js/components/workspaces/NewWorkspaceDialog/hooks';
import SummaryPaper from 'js/shared-styles/sections/SectionPaper';
Expand Down Expand Up @@ -141,6 +142,14 @@ function Template({ templateKey }: TemplatePageProps) {
</Stack>
</LabelledSectionText>
)}
{template?.last_modified_unix_timestamp && (
<LabelledSectionText
label="Last Modified"
iconTooltipText="Date when this template was last modified by its provider."
>
{format(template.last_modified_unix_timestamp * 1000, 'yyyy-MM-dd')}
</LabelledSectionText>
)}
</Stack>
</Stack>
{template.examples && (
Expand Down

0 comments on commit 8a7fffe

Please sign in to comment.