Skip to content

Commit

Permalink
add clarification
Browse files Browse the repository at this point in the history
  • Loading branch information
austenem committed Sep 23, 2024
1 parent 47b2548 commit e9b9cf7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ const tooltip = 'Launch New Workspace';
interface VisualizationWorkspaceButtonProps {
uuid?: string;
hubmap_id?: string;
mapped_data_access_level?: string;
hasNotebook?: boolean;
mapped_data_access_level?: string;
}

function VisualizationWorkspaceButton({
uuid = '',
hubmap_id,
mapped_data_access_level,
hasNotebook,
mapped_data_access_level,
}: VisualizationWorkspaceButtonProps) {
const { isWorkspacesUser } = useAppContext();
const { setDialogIsOpen, removeDatasets, ...rest } = useCreateWorkspaceForm({
Expand All @@ -31,7 +31,7 @@ function VisualizationWorkspaceButton({
initialSelectedDatasets: [uuid],
});

if (!isWorkspacesUser ?? mapped_data_access_level === 'Protected' ?? !uuid ?? !hubmap_id ?? !hasNotebook) {
if (!isWorkspacesUser ?? !uuid ?? !hubmap_id ?? !hasNotebook ?? mapped_data_access_level === 'Protected') {
return null;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ function IconDropdownMenu({ tooltip, icon, children }: PropsWithChildren<IconDro
return (
<>
<StyledSecondaryBackgroundTooltip title={tooltip}>
{/* Span is needed here for tooltip to appear without clicking */}
<span>
<WhiteBackgroundIconDropdownMenuButton menuID={tooltip}>
<SvgIcon component={icon} />
Expand Down

0 comments on commit e9b9cf7

Please sign in to comment.