John conroy/fix globus support #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-conroy
changed the base branch from
main
to
kevin-yoo/hmp-198-data-transfer-no-public-globus
lchoy
approved these changes
Jul 17, 2023
tsliaw
approved these changes
Jul 17, 2023
john-conroy
merged commit ce6ef92
into
kevin-yoo/hmp-198-data-transfer-no-public-globus
8 checks passed
kevinyooky
added a commit
that referenced
this pull request
Jul 17, 2023
* remove console * delete consoles * bulk data design setup * update padding to 16px all around * Gobus access message * bulk data transfer header * globus access styling * remove login button * Links to external sites * links styling * icon styling and alignment * Links alignment icons and styling * fix order of bulk data transfer * globus * add email icon * tooltip * target black rel noopener noreferrer * conditional logic for rendering files component * delete SRA bioproject section * icon size adjustment * fix files rendering logix * table of contents linked to section * logic for rendering files section * changelog * Update CHANGELOG-hmp-198-data-transfer-no-public-globus.md Co-authored-by: Nikolay Akhmetov <[email protected]> * Update context/app/static/js/components/detailPage/BulkDataTransfer/BulkDataTransfer.jsx Co-authored-by: John Conroy <[email protected]> * Update context/app/static/js/components/detailPage/BulkDataTransfer/BulkDataTransfer.jsx Co-authored-by: Nikolay Akhmetov <[email protected]> * remove duplicate files, create loggedin component to follow convention * correct name * fix typo in text * fix spacing and period placement in text * styledanchortag * remove tooltip for dbGaP study * tooltip for blocus Access * Update context/app/static/js/components/detailPage/BulkDataTransfer/NotLoggedIn/ProtectedData/DbGaP.jsx Co-authored-by: John Conroy <[email protected]> * Update context/app/static/js/pages/Dataset/Dataset.jsx Co-authored-by: Nikolay Akhmetov <[email protected]> * use python route for login * outboundlink cleanup * member login button styling * get color from theme and abstract it into styled component * remove unused typography from files, rename external link to link container * apply theme spacing * snake case * remove unused code * Links refactor * remove comments * componentize and eslint * variable name * add BlockIcon and clenaup * refactor outboundLink * fix updated import * fix import * refactor Links shared style * update path * remove unused style; * refactor Links component * Links component * refactor components to parent level; * Globus Link completed * implement mui divider * remove bulk data transfer from files section * changelog update * styling for globus link * add formating util function and style table of contents * logged in components set up * remove unused components * NoAccess component * QA component and NoAccess refactor * changelog update * cleanup * Add comment for context * ... * refactor for all scenarios * conditional logic for loggedIn * delete loggedIn directory * delete Links component * organize order of import files * add comment * change if else to switch statements * fix build error * cleanup; * policies link * remove globus access component * Update CHANGELOG-hmp-198-data-transfer-no-public-globus.md Co-authored-by: L Choy <[email protected]> * update changelog * outbound casing * datatest id * build fix testid update bulk-data-transfer * conditionals readability * fix conditional logic * extract bulkdatatransfer * refactor bulkDataTransferPanel * Handle no DbGap links * adjust publication page handling of files/bulkdatatransfer * fix useSwr fetch call and Invalid state * api call for globus link and globus support link * refactor details context * detailContext and filesContext usedetailcontext and usefilescontext refactor * unit test for functions * build fix * test file fix * remove unused file * remove unused globus from files directory * cleanup * tooltip for data support * tooltip fix * build error fix * unit test error * update content for logged in panel * cleanup * tooltip hover over entire link * build error fix * tooltip fix * Update CHANGELOG-hmp-198-data-transfer-no-public-globus.md Co-authored-by: Nikolay Akhmetov <[email protected]> * change block icon color to warning * changelog update * cleanup * Update context/app/static/js/pages/Publication/Publication.jsx Co-authored-by: Nikolay Akhmetov <[email protected]> * Update context/app/static/js/pages/Publication/Publication.jsx Co-authored-by: Nikolay Akhmetov <[email protected]> * build error fix * John conroy/fix globus support (#3179) * Add prop to show icon in files conditional link * Show tooltip on support globus links only * Remove unused styles * Fix dbGaP link styling --------- Co-authored-by: John Conroy <[email protected]> * Handle entity api failure for globus link (#3180) Co-authored-by: John Conroy <[email protected]> --------- Co-authored-by: Nikolay Akhmetov <[email protected]> Co-authored-by: John Conroy <[email protected]> Co-authored-by: L Choy <[email protected]> Co-authored-by: John Conroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling of Globus support links to reflect design. The tooltip should only be shown on support links.
Fix styling of dbGaP links.