-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Austenem/CAT-767 update workspace toast #3514
Conversation
context/app/static/js/components/workspaces/WorkspaceToastSuccessMessage.tsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/workspaces/WorkspaceToastSuccessMessage.tsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/workspaces/WorkspaceToastSuccessMessage.tsx
Outdated
Show resolved
Hide resolved
|
||
function WorkspaceToastSuccessMessage(id: number) { | ||
return ( | ||
<Stack sx={{ maxWidth: '22rem' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this maxWidth
in particular?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was from the designs - without a maxWidth, the toast stretches across the bottom of the screen and is hard to read. Is there a better method for setting width options like these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would fit-content
work? https://developer.mozilla.org/en-US/docs/Web/CSS/max-width#fit-content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context/app/static/js/components/workspaces/WorkspaceToastSuccessMessage.tsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/workspaces/WorkspaceToastSuccessMessage.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for experimenting with the other max width options. We can keep the current approach (with one minor adjustment).
context/app/static/js/components/workspaces/WorkspaceLaunchSuccessToast.tsx
Outdated
Show resolved
Hide resolved
…cessToast.tsx Co-authored-by: Nikolay Akhmetov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes!
Summary
Update language and add an action button to toasts for successful workspace creation. This also takes care of notifying users that workspaces are launched in a new tab and to watch out for their pop-up settings.
Design Documentation/Original Tickets
CAT-767 Jira ticket
Figma mockup
Testing
Visual comparison to mockups, ensured that button links to the correct workspace detail page.
Screenshots/Video
Checklist
CHANGELOG-your-feature-name-here.md
is present in the root directory, describing the change(s) in full sentences.