Austenem/CAT-767 update workspace toast #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
context/app/static/js/components/workspaces/WorkspaceToastSuccessMessage.tsx
Outdated
Show resolved
Hide resolved
NickAkhmetov
previously approved these changes
Aug 22, 2024
john-conroy
requested changes
Aug 23, 2024
context/app/static/js/components/workspaces/WorkspaceToastSuccessMessage.tsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/workspaces/WorkspaceToastSuccessMessage.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| function WorkspaceToastSuccessMessage(id: number) { | ||
| return ( | ||
| <Stack sx={{ maxWidth: '22rem' }}> |
There was a problem hiding this comment.
Why this maxWidth in particular?
There was a problem hiding this comment.
This was from the designs - without a maxWidth, the toast stretches across the bottom of the screen and is hard to read. Is there a better method for setting width options like these?
There was a problem hiding this comment.
Would fit-content work? https://developer.mozilla.org/en-US/docs/Web/CSS/max-width#fit-content
There was a problem hiding this comment.
That's a bit better than the 100% width - it still stretches out further than the designs, because I think the max-content is higher than 20rem. The <length-percentage> parameter doesn't seem to change anything, which is a bit odd:
context/app/static/js/components/workspaces/WorkspaceToastSuccessMessage.tsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/workspaces/WorkspaceToastSuccessMessage.tsx
Outdated
Show resolved
Hide resolved
context/app/static/js/components/workspaces/WorkspaceLaunchSuccessToast.tsx
Outdated
Show resolved
Hide resolved
…cessToast.tsx Co-authored-by: Nikolay Akhmetov <[email protected]>
NickAkhmetov
approved these changes
Aug 26, 2024
john-conroy
approved these changes
Aug 26, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update language and add an action button to toasts for successful workspace creation. This also takes care of notifying users that workspaces are launched in a new tab and to watch out for their pop-up settings.
Design Documentation/Original Tickets
CAT-767 Jira ticket
Figma mockup
Testing
Visual comparison to mockups, ensured that button links to the correct workspace detail page.
Screenshots/Video
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.