Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Austenem/CAT-898 R template updates #3540
Austenem/CAT-898 R template updates #3540
Changes from 9 commits
dae8a34
f81e10f
3abf78f
3685188
5c647a7
736b2fd
7cc39d8
f1aa049
3959abd
d35f8fe
12107b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this assertion necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this,
jobType.value
could potentially be a string array - however I believe theworkspaceJobTypeIdField
defines the field value as a string.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like
workspaceJobTypeId
isn't defined inFormType
, which only containstemplates: string[]
since it extendsFormWithTemplates
:Since there's no property name that matches
workspaceJobTypeIdField
in the form type, TS treats this as either a string or string-array by default.I believe that extending FormType to include workspace ID should work, e.g.:
I tested this approach out to see if it would work, but it doesn't seem to do the trick, oddly enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we file a ticket to resolve this later?