Austenem/CAT-873 add donor age messaging #3548
Conversation
context/app/static/js/components/entity-tile/EntityTileBody/EntityTileBody.tsx
Show resolved
Hide resolved
context/app/static/js/components/entity-tile/EntityTileBody/EntityTileBody.tsx
Outdated
Show resolved
Hide resolved
I can definitely do that, but the metadata table already has this language in the top info banner - I'd be in favor of replacing that with an inline tooltip like the rest of the messaging, or including both. @tsliaw? |
|
@austenem I would be fine with a tooltip for the metadata table to keep it consistent. Let's remove the messaging in the info textbox. I think the messaging appears in enough places to be clear about what's going on in this scenario. |
context/app/static/js/components/detailPage/MetadataTable/MetadataTable.tsx
Outdated
Show resolved
Hide resolved
| {fieldValue.join(' / ')} | ||
| <DonorAgeTooltip donorAge={fieldValue.join(' / ')} /> |
There was a problem hiding this comment.
Will this be able to be converted with Number?
There was a problem hiding this comment.
Yes, because the fieldValue array only contains one element - but it might be a bit safer to take only the first element of fieldValue.
| @@ -55,7 +55,7 @@ function getByPath(hitSource, field) { | |||
| return ( | |||
| <Stack direction="row"> | |||
| {fieldValue.join(' / ')} | |||
| <DonorAgeTooltip donorAge={fieldValue.join(' / ')} /> | |||
| <DonorAgeTooltip donorAge={fieldValue[0]} /> | |||
There was a problem hiding this comment.
You should check that fieldValue is non-empty.
|
Re-ran cypress. Merge once passing. |
Summary
Add messaging where donors with ages > 89 are displayed on search and detail pages, and cap age filter on search page at 90 years.
Design Documentation/Original Tickets
CAT-873 Jira ticket
Testing
Tested for both 90+ aged donors.
Screenshots/Video
Search page:
Dataset detail page:
Donor detail page:
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.