Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

John conroy/fix template resource #3550

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

john-conroy
Copy link
Collaborator

Summary

Fix bug where template examples with default resource options would not launch.

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Copy link
Collaborator

@austenem austenem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having issues checking this out locally, but looks good to me.

@austenem
Copy link
Collaborator

Was able to check out - everything looks good and the template issue is resolved.

@john-conroy john-conroy merged commit da26bf9 into main Sep 25, 2024
8 checks passed
@john-conroy john-conroy deleted the john-conroy/fix-template-resource branch September 25, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants