-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Austenem/CAT-883, CAT-914, CAT-870, CAT-868 #3552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nicely done!
Just a few small non-blocking suggestions.
@@ -41,6 +43,8 @@ export const createEntityStore = ({ springs }: { springs: ReturnType<typeof useS | |||
summaryEntry: entry, | |||
}, | |||
}), | |||
summaryHeight: 0, | |||
setSummaryHeight: (val: number) => set({ summaryHeight: val }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocker, just an idea:
setSummaryHeight: (val: number) => set({ summaryHeight: val }), | |
setSummaryHeight: (summaryHeight: number) => set({ summaryHeight }), |
@@ -41,6 +43,8 @@ export const createEntityStore = ({ springs }: { springs: ReturnType<typeof useS | |||
summaryEntry: entry, | |||
}, | |||
}), | |||
summaryHeight: 0, | |||
setSummaryHeight: (val: number) => set({ summaryHeight: val }), | |||
view: 'narrow' as const, | |||
setView: (val) => set({ view: val }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, could have the arg be named "view" here 😄
Summary
Four minor/style bug fixes on the search, detail, and home pages.
Design Documentation/Original Tickets
CAT-868: Adjust size of "summary" view in entity headers dynamically based on the length of the content.
CAT-870: Update unified datasets link in "What’s New" section on homepage to point to an example dataset detail page.
CAT-883: Fix positioning of dropdown order menu on the tile view of the search page
CAT-914: Fix tabs moving around in bulk data transfer section on detail pages.
Testing
Manually tested all bugs, confirmed with screenshots.
Screenshots/Video
CAT-868
Issue (excess whitespace):
Fix:
CAT-870
Issue (previous redirect):
Fix (updated redirect):
CAT-883
Issue:
Fix:
CAT-914
Issue:
Screen.Recording.2024-09-30.at.10.36.02.AM.mov
Fix:
Screen.Recording.2024-09-27.at.11.09.02.AM.mov
Checklist
CHANGELOG-your-feature-name-here.md
is present in the root directory, describing the change(s) in full sentences.