Austenem/CAT-929 double dialog bug #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-conroy
reviewed
Oct 1, 2024
context/app/static/js/components/workspaces/AddDatasetsFromSearchOrDetailDialog/hooks.ts
Outdated
Show resolved
Hide resolved
context/app/static/js/components/detailPage/ProcessedData/ProcessedDataWorkspaceMenu.tsx
Outdated
Show resolved
Hide resolved
john-conroy
reviewed
Oct 2, 2024
context/app/static/js/components/detailPage/ProcessedData/HelperPanel/HelperPanel.tsx
Outdated
Show resolved
Hide resolved
john-conroy
reviewed
Oct 2, 2024
john-conroy
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug present on the dataset detail pages. Previously, the "Add to Workspace" dialog could not be saved, and opened two dialogs simultaneously.
Design Documentation/Original Tickets
CAT-929 Jira ticket
Testing
Tested manually that dialogs worked as expected for both the entity header and the helper menu workspace options. Also tested that search page dialog continued to work as expected.
Screenshots/Video
Issue present on prod:
Screen.Recording.2024-10-01.at.11.52.09.AM.mov
Resolution:
Screen.Recording.2024-10-01.at.11.51.39.AM.mov
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.Additional Notes
For clarity, the cause of the bug was that there were two "Add dataset to workspace" dialogs - one for the helper menu, and one for the entity header - and both depended on a single boolean to determine whether they were open. As a result, whenever one was opened, the other would open behind it.
This was resolved by using one dialog for both the helper menu and the entity header and storing the relevant dataset to use in the dialog, which also resolved the issue of the dialog not responding.