Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/CAT-419 Filter collections without DOI from being counted on homepage #3564

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

NickAkhmetov
Copy link
Collaborator

Summary

This PR adds a query to the aggregation on the homepage which prevents collection entities without a registered/published DOI from being included in the counts while not impacting the other counts. This filtering behavior matches the conditions applied to the count and list on the collections page.

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-419

Testing

Manual testing/comparison to the logged in portal.

Screenshots/Video

Hovering the samples count to verify the added query does not affect any of the other entity counts; the actual fix can be seen by checking the collections count on the right.

Logged in on prod:
image

Logged in locally:
image

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Additional Notes

Not sure how else to test this functionality; the idea of using an e2e test to compare the counts came to mind, but since this issue was only observable while logged in as a HIVE user, that approach will not work.

Copy link
Collaborator

@austenem austenem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@NickAkhmetov NickAkhmetov merged commit 8144804 into main Oct 9, 2024
8 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/cat-419-collection-counts branch October 9, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants