NickAkhmetov/CAT-419 Filter collections without DOI from being counted on homepage #3564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a query to the aggregation on the homepage which prevents collection entities without a registered/published DOI from being included in the counts while not impacting the other counts. This filtering behavior matches the conditions applied to the count and list on the collections page.
Design Documentation/Original Tickets
https://hms-dbmi.atlassian.net/browse/CAT-419
Testing
Manual testing/comparison to the logged in portal.
Screenshots/Video
Hovering the samples count to verify the added query does not affect any of the other entity counts; the actual fix can be seen by checking the collections count on the right.
Logged in on prod:
Logged in locally:
Checklist
CHANGELOG-your-feature-name-here.md
is present in the root directory, describing the change(s) in full sentences.Additional Notes
Not sure how else to test this functionality; the idea of using an e2e test to compare the counts came to mind, but since this issue was only observable while logged in as a HIVE user, that approach will not work.