-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Austenem/CAT-934 Update metadata sections #3568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice job! Just a few small questions that occurred to me.
context/app/static/js/components/detailPage/MetadataSection/utils.ts
Outdated
Show resolved
Hide resolved
context/app/static/js/components/detailPage/MetadataSection/utils.ts
Outdated
Show resolved
Hide resolved
context/app/static/js/components/detailPage/MetadataSection/utils.ts
Outdated
Show resolved
Hide resolved
NickAkhmetov
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This update impacts the Metadata section of the Sample, Donor, and Dataset detail pages.
Design Documentation/Original Tickets
CAT-934 Jira ticket
Testing
Tested by checking several examples of each type of detail page to ensure the data in the metadata section matched that of the provenance section. If an entity from the provenance table was not included, I checked the entity's JSON to ensure it actually had no metadata.
Also tested helpers with unit tests.
Screenshots/Video
Sample example
(Local on left, prod on right)
Dataset examples
(Local on left, prod on right)
Donor example
(Local on left, prod on right)
Checklist
CHANGELOG-your-feature-name-here.md
is present in the root directory, describing the change(s) in full sentences.