Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/CAT-949 Remove provenance section, convert donor page to TypeScript #3571

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

NickAkhmetov
Copy link
Collaborator

Summary

After investigations related to CAT-751, Zhou and Bill have determined there is no longer any provenance information to display for donors. Historically, there were lab nodes which were showing up but did not have any related information, so they removed them approximately 4 months ago. As a result, the provenance graphs no longer had any valid relationships to display, so they crashed; therefore, removing this section in favor of the derived entities section removes an unnecessary visual component.

I have also converted the Donor detail page to TypeScript, resolved any resulting reported type errors, and updated the Protocols component to use the withShouldDisplay HOC.

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-751
https://hms-dbmi.atlassian.net/browse/CAT-949

Testing

I A/B tested this donor page: https://portal.hubmapconsortium.org/browse/donor/a0bdb4249eb3a6bd1865f948875c2f96 on production and local.

Screenshots/Video

Production screenshot (Note that prod is also missing organ data in the screenshot, this was fixed in #3567)

image

Fixed screenshot

image

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Additional Notes

I think we can probably do a lot more with the Summary section of donor pages. Right now the information there is very minimal - I think we should surface some useful information so people can learn more about the donor at a glance, e.g. demographic info, organs that were analyzed from this donor, etc.

austenem
austenem previously approved these changes Oct 15, 2024
Copy link
Collaborator

@austenem austenem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Regarding your comment about better utilizing the summary section for donor pages - I think that's a good point, but it looks like metadata like demographics, organ info, etc isn't available for many of the donors. In this example I found where that metadata was present, it was included in the summary section:

Screenshot 2024-10-15 at 2 20 57 PM

@NickAkhmetov NickAkhmetov merged commit 56d8012 into main Oct 16, 2024
8 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/cat-949-remove-prov-from-donors branch October 16, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants