NickAkhmetov/CAT-949 Remove provenance section, convert donor page to TypeScript #3571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After investigations related to CAT-751, Zhou and Bill have determined there is no longer any provenance information to display for donors. Historically, there were lab nodes which were showing up but did not have any related information, so they removed them approximately 4 months ago. As a result, the provenance graphs no longer had any valid relationships to display, so they crashed; therefore, removing this section in favor of the derived entities section removes an unnecessary visual component.
I have also converted the Donor detail page to TypeScript, resolved any resulting reported type errors, and updated the Protocols component to use the
withShouldDisplay
HOC.Design Documentation/Original Tickets
https://hms-dbmi.atlassian.net/browse/CAT-751
https://hms-dbmi.atlassian.net/browse/CAT-949
Testing
I A/B tested this donor page: https://portal.hubmapconsortium.org/browse/donor/a0bdb4249eb3a6bd1865f948875c2f96 on production and local.
Screenshots/Video
Production screenshot (Note that prod is also missing organ data in the screenshot, this was fixed in #3567)
Fixed screenshot
Checklist
CHANGELOG-your-feature-name-here.md
is present in the root directory, describing the change(s) in full sentences.Additional Notes
I think we can probably do a lot more with the
Summary
section of donor pages. Right now the information there is very minimal - I think we should surface some useful information so people can learn more about the donor at a glance, e.g. demographic info, organs that were analyzed from this donor, etc.