-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Austenem/CAT-957 Basic page tests #3576
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9fba498
resolve current cypress errors
austenem 8ce8858
add first loading tests
austenem 7e90492
add tests for all landing pages
austenem 308a6eb
add detail page tests
austenem fa161ca
add additional detail page checks
austenem e52bca9
add template and tutorial tests
austenem eab952e
organize testing files
austenem 572676d
add changelog
austenem 5589c31
update cypress script
austenem cf70bc2
update test id
austenem e108d05
add maintenance back
austenem d09e35d
Update end-to-end/cypress/e2e/portal/pages/publication.cy.js
austenem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
- Add end-to-end tests that check whether all page types load successfully. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,6 +54,7 @@ function TemplateGrid({ | |
label: title, | ||
}) | ||
} | ||
data-testid="template-card" | ||
> | ||
{title} | ||
</InternalLink> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
6 changes: 3 additions & 3 deletions
6
.../e2e/portal/dataset-search-tutorial.cy.js → ...ortal/flows/dataset-search-tutorial.cy.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
/****************************************************************************************** | ||
* | ||
* Tests whether all page types load successfully. | ||
* | ||
* Description: | ||
* ---------------------------------------------------------------------------- | ||
* Checks that the title element of each page type is visible. Navigates to an example of | ||
* each detail page by clicking on the first available option from the list/table. | ||
* | ||
******************************************************************************************/ | ||
|
||
describe("Landing pages all load", () => { | ||
const pages = [ | ||
{ name: "Biomarkers", url: "/biomarkers", testId: "biomarkers-title" }, | ||
{ name: "Collections", url: "/collections", testId: "collections-title" }, | ||
{ name: "Datasets", url: "/search?entity_type[0]=Dataset", testId: "search-header" }, | ||
{ name: "Dev Search", url: "/dev-search", testId: "dev-search-title" }, | ||
{ name: "Donor Diversity", url: "/diversity", testId: "diversity-title" }, | ||
{ name: "Donors", url: "/search?entity_type[0]=Donor", testId: "search-header" }, | ||
{ name: "Home", url: "/", testId: "home-page-title" }, | ||
{ name: "My Lists", url: "/my-lists", testId: "my-lists-title" }, | ||
{ name: "My Workspaces", url: "/workspaces", testId: "my-workspaces-title" }, | ||
{ name: "Molecular Data Queries", url: "/cells", testId: "molecular-data-queries-title" }, | ||
{ name: "Organs", url: "/organ", testId: "organs-title" }, | ||
{ name: "Profile", url: "/profile", testId: "login-alert" }, | ||
{ name: "Publications", url: "/publications", testId: "publications-title" }, | ||
{ name: "Samples", url: "/search?entity_type[0]=Sample", testId: "search-header" }, | ||
{ name: "Services", url: "/services", testId: "services-title" }, | ||
{ name: "Templates", url: "/templates", testId: "templates-title" }, | ||
{ name: "Tutorials", url: "/tutorials", testId: "tutorials-title" }, | ||
]; | ||
|
||
context("macbook-size", () => { | ||
beforeEach(() => { | ||
cy.viewport("macbook-15"); | ||
}); | ||
|
||
pages.forEach((page) => { | ||
it(`loads ${page.name} page`, () => { | ||
cy.visit(page.url); | ||
cy.findByTestId(page.testId).should("exist").and("be.visible"); | ||
}); | ||
}); | ||
}); | ||
}); | ||
|
||
describe("Entity detail page all load", () => { | ||
const pages = [ | ||
{ name: "Collection", url: "/collections", testId: "panel-title" }, | ||
{ name: "Dataset", url: "/search?entity_type[0]=Dataset", testId: "hubmap-id-link" }, | ||
{ name: "Donor", url: "/search?entity_type[0]=Donor", testId: "hubmap-id-link" }, | ||
{ name: "Organ", url: "/organ", testId: "organ-tile" }, | ||
{ name: "Publication", url: "/publications", testId: "panel-title" }, | ||
{ name: "Sample", url: "/search?entity_type[0]=Sample", testId: "hubmap-id-link" }, | ||
]; | ||
|
||
context("macbook-size", () => { | ||
beforeEach(() => { | ||
cy.viewport("macbook-15"); | ||
}); | ||
|
||
pages.forEach((page) => { | ||
it(`loads a ${page.name} detail page`, () => { | ||
cy.visit(page.url); | ||
cy.findAllByTestId(page.testId).first().click(); | ||
cy.findByTestId("entity-title").should("exist").and("be.visible"); | ||
}); | ||
}); | ||
}); | ||
}); | ||
|
||
describe("Other detail pages all load", () => { | ||
const pages = [ | ||
{ name: "Tutorial", url: "/tutorials", testId: "tutorial-card", titleTestId: "tutorial-title" }, | ||
{ name: "Template", url: "/templates", testId: "template-card", titleTestId: "entity-title" }, | ||
]; | ||
|
||
context("macbook-size", () => { | ||
beforeEach(() => { | ||
cy.viewport("macbook-15"); | ||
}); | ||
|
||
pages.forEach((page) => { | ||
it(`loads a ${page.name} page`, () => { | ||
cy.visit(page.url); | ||
cy.findAllByTestId(page.testId).first().click(); | ||
cy.findByTestId(page.titleTestId).should("exist").and("be.visible"); | ||
}); | ||
}); | ||
}); | ||
}); |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may be able to add corresponding intercept commands for
storage.googleapis.com
,data-2.vitessce.io
, and any other domains Vitessce loads from if these are a concernThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point! This isn't an active concern on my end - these two tests are copied over from a file that was deleted as part of a reorganization effort, so this comment is from that original file. I think the page content tests should be expanded and will definitely incorporate more network interceptions during the next round of tests.