Updated HRA EUI and organ-info web components to latest version #3577
Conversation
| @@ -19,8 +19,7 @@ function Switch({ organs_count }) { | |||
| return ( | |||
| <ccf-organ-info | |||
| organ-iri={iri} | |||
| use-remote-api="true" | |||
| remote-api-endpoint="https://apps.humanatlas.io/hubmap-hra-api/v1" | |||
| data-sources='["https://apps.humanatlas.io/api/ds-graph/hubmap?token="]' | |||
There was a problem hiding this comment.
| data-sources='["https://apps.humanatlas.io/api/ds-graph/hubmap?token="]' | |
| data-sources='["https://apps.humanatlas.io/api/ds-graph/hubmap"]' |
Do we need the empty token param?
There was a problem hiding this comment.
It is preferable to keep the ?token= for caching purposes as the EUI uses the same data sources string and will be cached across both products.
There was a problem hiding this comment.
@bherr2 could you make the corresponding updates to the organ-info script/styles links here? https://github.com/hubmapconsortium/portal-ui/blob/update-hra/context/app/static/js/components/HRA/CCFOrganInfo.tsx#L29-L30
| <title>HuBMAP HRA Exploration User Interface</title> | ||
| <base href="https://cdn.humanatlas.io/ui/ccf-eui/" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <link rel="icon" type="image/png" href="/favicon.png" /> |
There was a problem hiding this comment.
| <link rel="icon" type="image/png" href="/favicon.png" /> | |
| <link rel="icon" type="image/x-icon" href="/favicon.ico" /> |
We have a .ico icon, not a .png icon: https://github.com/hubmapconsortium/portal-ui/blob/main/context/app/static/favicon.ico
There was a problem hiding this comment.
This actually refers to the favicon at https://cdn.humanatlas.io/ui/ccf-eui/ as it is using https://cdn.humanatlas.io/ui/ccf-eui/ as the base-href (see line 7)
There was a problem hiding this comment.
Ah, right, good call - I missed that detail.
I think it'll be all set to merge if the CCFOrganInfo component is up to date.
There was a problem hiding this comment.
Ok, sounds good. Like I said with the organ info, I'd like to keep the ?token= as is since it will help tremendously with caching/responsiveness.
There was a problem hiding this comment.
Yes - my question is about the values here: https://github.com/hubmapconsortium/portal-ui/blob/update-hra/context/app/static/js/components/HRA/CCFOrganInfo.tsx#L29-L30
There was a problem hiding this comment.
Oh! Thank you, yes, I'll get those updated.
|
Thank you! |
Updated both the EUI and organ-info web components. I'm not able to test this locally. It should work fine, but please give it a local test.