Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/CAT-1010 Integrate Cellpop into organ page #3674

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

NickAkhmetov
Copy link
Collaborator

@NickAkhmetov NickAkhmetov commented Jan 23, 2025

Summary

This PR adds cellpop visualizations to the organ page. This is best observed on the kidney page.

Current limitations

  • Visualizations are currently limited to only include datasets which are known to be labeled. Once we enhance the search API to include annotation information, the query that fetches UUIDs should be revised to use that field and the predefined UUID list should be dropped.

Remaining todos

  • Minor visual improvements to match the designs more closely
  • Track down and resolve accordion margin regression
  • Add test coverage
  • Add analytics

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-1010

Testing

Manually tested on:

Screenshots/Video

Kidney page

image

Heart Page

image

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Additional Notes

Other minor changes in this PR:

  • I started building out a dark theme to make the cellpop visualization look okay in the context of the portal UI.
  • I updated React from 18.2.0 to 18.3.1. This update does not introduce any differences in functionality, but does add warning logs to highlight what needs to be updated in order to prepare for React 19's update.
  • I did some slight reorganization of the main organ page to move the lookup queries into their own hooks.
  • The visualization store is slightly updated to handle expanding non-Vitessce visualizations. Maybe worthwhile to add "expand" functionalities to the EUI components?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant