Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scripting tasks config vignette #86

Merged
merged 26 commits into from
Dec 24, 2024
Merged
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
53b1396
migrate scripting config tutorial to here
zkamvar Nov 25, 2024
23f72ec
use dev version of pkgdown
zkamvar Dec 5, 2024
3ac39d1
halfway through first pass
zkamvar Dec 6, 2024
7fc2cd6
dangit linter
zkamvar Dec 6, 2024
1c5114a
finalize vignette
zkamvar Dec 6, 2024
e3871a0
fix loooooong comments
zkamvar Dec 6, 2024
f29a854
update pkgdown workflow
zkamvar Dec 6, 2024
9614b2c
Apply suggestions from code review
zkamvar Dec 10, 2024
7eb711b
minor typo fixes
zkamvar Dec 10, 2024
cf8e27a
remove comments
zkamvar Dec 10, 2024
c061b97
add todo
zkamvar Dec 10, 2024
e7b7fb7
remove second paragraph
zkamvar Dec 10, 2024
90f6018
Update vignettes/articles/scripting-tasks-config.Rmd
zkamvar Dec 10, 2024
8e8ed51
remove class before testing if validate output is false
zkamvar Dec 11, 2024
cf519c0
add version option; mention output type id datatype arg
zkamvar Dec 11, 2024
1f810c2
no need for new pkgdown
zkamvar Dec 11, 2024
03ff6a9
Apply suggestions from code review
zkamvar Dec 11, 2024
1c4c8bc
Apply suggestions from code review
zkamvar Dec 23, 2024
b78bc89
add notes to the unclassed tests
zkamvar Dec 23, 2024
0ebd33d
clarify structure of the round objects.
zkamvar Dec 23, 2024
99d2e95
Merge branch 'main' into znk/task-config-vignette
zkamvar Dec 24, 2024
30ad619
fix round id thing
zkamvar Dec 24, 2024
4889b55
remove section on errors due to duplicate round IDs
zkamvar Dec 24, 2024
0d97d0c
Apply suggestions from code review
zkamvar Dec 24, 2024
01484bd
fix dang indentation
zkamvar Dec 24, 2024
dac3b89
Update vignettes/articles/scripting-tasks-config.Rmd
zkamvar Dec 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/pkgdown-netlify-preview.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
contents: write
pull-requests: write
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: r-lib/actions/setup-tinytex@v2

Expand All @@ -53,13 +53,20 @@ jobs:
clean: false
branch: gh-pages
folder: docs

- id: deploy-dir
name: Determine dev status
run: |
if [[ $(grep -c -E 'sion. ([0-9]*\.){3}' ${{ github.workspace }}/DESCRIPTION) == 1 ]]; then
echo 'dir=./docs/dev' >> $GITHUB_OUTPUT
else
echo 'dir=./docs' >> $GITHUB_OUTPUT
fi
- name: Deploy PR preview to Netlify
if: contains(env.isPush, 'false')
id: netlify-deploy
uses: nwtgck/actions-netlify@v2
uses: nwtgck/actions-netlify@v3
with:
publish-dir: './docs'
publish-dir: '${{ steps.deploy-dir.outputs.dir }}'
production-branch: main
github-token: ${{ secrets.GITHUB_TOKEN }}
deploy-message:
Expand Down
6 changes: 6 additions & 0 deletions tests/testthat/test-validate_model_metadata_schema.R
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ test_that("Missing files returns an invalid config with an immediate message", {
"File does not exist"
)
})
# NOTE: this needs to be unclassed because otherwise testthat assumes it is
# an error: https://github.com/hubverse-org/hubAdmin/pull/86/files#r1882552109
expect_false(unclass(out))
zkamvar marked this conversation as resolved.
Show resolved Hide resolved
})

Expand All @@ -28,6 +30,8 @@ test_that("validate_model_metadata_schema works", {
)
)
)
# NOTE: this needs to be unclassed because otherwise testthat assumes it is
# an error: https://github.com/hubverse-org/hubAdmin/pull/86/files#r1882552109
expect_false(unclass(out_error))
expect_snapshot(out_error) # prints .Last.value
expect_snapshot(print(out_error)) # prints out_error
Expand All @@ -51,6 +55,8 @@ test_that("validate_model_metadata_schema errors for imparsable json", {
"SyntaxError"
)
})
# NOTE: this needs to be unclassed because otherwise testthat assumes it is
# an error: https://github.com/hubverse-org/hubAdmin/pull/86/files#r1882552109
expect_false(unclass(out))

})
Loading
Loading