Make latest snaphots version agnostic #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces it with "latest".
Only the contents of the latest schema version are now of interests in tests and not the version numbers themselves. This means we do need to chnage tests everytime a new version is released, unless it actually affects the outputs of functions.
…der schema version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #93 and is designed to make updating tests when new schema are released much smoother
More specifically it adds helper function
verify_latest_schema_version()which checks that theschema_idattribute of the output of any of thecreate_*()family of functions matches the latest available schema version. If it does, it overwrites theschema_idattribute (andschema_versionproperty in a config class object) with"latest".This in turn means we do not have to update the version number of expected outputs everytime a new schema is released in tests where we want to be checking the outputs of functions against the latest schema.
I also fixed the versions of some tests which weren't testing functionality affected by changes in schema.
I also removed any obsolete mentions of specific branches (these will no longer be required with the new
hubUtilsworkflow anyways in future as the schema under development will be available in the dev version ofhubUtils)