[REFACTOR] 타임라인이 경기에 주는 영향을 apply 메서드로 명시적으로 호출 #206

hufscheer · Aug 18, 2024 · 469036d · 469036d
1 parent a1042e1
commit 469036d
Show file tree

Hide file tree

Showing 7 changed files with 30 additions and 2 deletions.
diff --git a/src/main/java/com/sports/server/command/timeline/application/TimelineService.java b/src/main/java/com/sports/server/command/timeline/application/TimelineService.java
@@ -25,6 +25,8 @@ public void register(Member member, Long gameId, TimelineRequest request) {
         Game game = checkPermissionAndGet(gameId, member);
 
         Timeline timeline = timelineMapper.toEntity(game, request);
+        timeline.apply();
+
         timelineRepository.save(timeline);
     }
 

diff --git a/src/main/java/com/sports/server/command/timeline/domain/GameProgressTimeline.java b/src/main/java/com/sports/server/command/timeline/domain/GameProgressTimeline.java
@@ -32,6 +32,11 @@ public String getType() {
         return "GAME_PROGRESS";
     }
 
+    @Override
+    public void apply() {
+        // TODO Game 상태 변경
+    }
+
     @Override
     public void rollback() {
         // TODO 게임 상태 변경 타임라인 생성 로직 구현 이후 구현 예정

diff --git a/src/main/java/com/sports/server/command/timeline/domain/PKTimeline.java b/src/main/java/com/sports/server/command/timeline/domain/PKTimeline.java
@@ -21,6 +21,10 @@ public String getType() {
         return "PK";
     }
 
+    @Override
+    public void apply() {
+    }
+
     @Override
     public void rollback() {
     }

diff --git a/src/main/java/com/sports/server/command/timeline/domain/ReplacementTimeline.java b/src/main/java/com/sports/server/command/timeline/domain/ReplacementTimeline.java
@@ -48,6 +48,11 @@ private void validatePlayers(LineupPlayer originLineupPlayer, LineupPlayer repla
         }
     }
 
+    @Override
+    public void apply() {
+
+    }
+
     @Override
     public void rollback() {
     }

diff --git a/src/main/java/com/sports/server/command/timeline/domain/ScoreTimeline.java b/src/main/java/com/sports/server/command/timeline/domain/ScoreTimeline.java
@@ -48,8 +48,6 @@ public static ScoreTimeline score(
             Integer recordedAt,
             LineupPlayer scorer
     ) {
-        game.score(scorer);
-
         GameTeam team1 = game.getTeam1();
         GameTeam team2 = game.getTeam2();
 
@@ -87,6 +85,14 @@ private ScoreTimeline(
         this.snapshotScore2 = snapshotScore2;
     }
 
+    @Override
+    public void apply() {
+        game.score(scorer);
+
+        snapshotScore1 = gameTeam1.getScore();
+        snapshotScore2 = gameTeam2.getScore();
+    }
+
     @Override
     public void rollback() {
         game.cancelScore(scorer);

diff --git a/src/main/java/com/sports/server/command/timeline/domain/Timeline.java b/src/main/java/com/sports/server/command/timeline/domain/Timeline.java
@@ -47,5 +47,7 @@ private void validateRecordedAt(Integer recordedAt) {
         }
     }
 
+    public abstract void apply();
+
     public abstract void rollback();
 }
diff --git a/src/test/java/com/sports/server/command/timeline/domain/ScoreTimelineTest.java b/src/test/java/com/sports/server/command/timeline/domain/ScoreTimelineTest.java
@@ -55,6 +55,8 @@ class CreateTest {
                     scorer
             );
 
+            timeline.apply();
+
             // then
             assertThat(timeline.getScorer()).isEqualTo(scorer);
             assertThat(timeline.getSnapshotScore1()).isEqualTo(2);
@@ -76,6 +78,8 @@ class CreateTest {
                     scorer
             );
 
+            timeline.apply();
+
             // then
             assertThat(timeline.getScorer()).isEqualTo(scorer);
             assertThat(timeline.getSnapshotScore1()).isEqualTo(1);