Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs on grad accumulation #1817

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Improve docs on grad accumulation #1817

merged 5 commits into from
Aug 7, 2023

Conversation

vwxyzjn
Copy link
Contributor

@vwxyzjn vwxyzjn commented Aug 7, 2023

Also added a self-contained runnable example.

@vwxyzjn vwxyzjn requested a review from muellerzr August 7, 2023 02:48
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 7, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

muellerzr
muellerzr reviewed Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Along with Sylvain's comments a few style nits in your example.

docs/source/usage_guides/gradient_accumulation.md Outdated Show resolved Hide resolved
docs/source/usage_guides/gradient_accumulation.md Outdated Show resolved Hide resolved
@vwxyzjn
Copy link
Contributor Author

vwxyzjn commented Aug 7, 2023

Hi @muellerzr and @sgugger thanks for the prompt review. Let me know if further changes are needed :)

sgugger
sgugger approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

docs/source/usage_guides/gradient_accumulation.md Outdated Show resolved Hide resolved
muellerzr
muellerzr approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (With Sylvain's spacing nit for our docs :) )

@sgugger sgugger merged commit b42c65b into main Aug 7, 2023
3 checks passed
@sgugger sgugger deleted the docs-grad-acc branch August 7, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@muellerzr muellerzr muellerzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vwxyzjn @HuggingFaceDocBuilderDev @muellerzr @sgugger