Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs and docstrings to match load_and_quantize_model arg #1822

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Update docs and docstrings to match load_and_quantize_model arg #1822

merged 2 commits into from
Aug 8, 2023

Conversation

JonathanRayner
Copy link
Contributor

load_and_quantize_model has an arg bnb_quantization_config, but slightly different versions of this were listed in the docs and docstrings.

sgugger
sgugger approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also have a look and merge if you're happy @SunMarc ?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 8, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

SunMarc
SunMarc approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs and docstings!

@SunMarc SunMarc merged commit 39897a0 into huggingface:main Aug 8, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunMarc SunMarc SunMarc approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JonathanRayner @HuggingFaceDocBuilderDev @sgugger @SunMarc