Deepspeed integration for XPU/ccl #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @pacman100 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
@pacman100 could you take a look ? Thanks |
|
@sgugger any updates/reviews on this PR ? Thanks |
|
Still waiting for @pacman100 to take a look. |
pacman100
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Thank you @abhilash1910 for adding support for XPU when using DeepSpeed. LGTM!
|
@pacman100 You will need to merge the PR if you are happy with it ;-) |
LysandreJik
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deepspeed has exposed support to different backends .So for using deepspeed through accelerate on xpus, the ccl backend is required. Also mpich support was added in deepspeed before (by me) so that can be added too for multinode.
@sgugger @muellerzr