Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove casting to FP32 when saving state dict #1868

Merged
merged 2 commits into from
Aug 21, 2023
Merged

remove casting to FP32 when saving state dict #1868

merged 2 commits into from
Aug 21, 2023

Conversation

pacman100
Copy link
Contributor

What does this PR do?

  1. Fixes save_state causes CUDA allocations #1865

@pacman100 pacman100 requested review from sgugger and muellerzr and removed request for sgugger August 21, 2023 10:35
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 21, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

muellerzr
muellerzr approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@muellerzr
Copy link
Collaborator

We may(?) Want to update the doc for save_state to mention it will maintain the precision mode thr model is currently in

@pacman100
Copy link
Contributor Author

We may(?) Want to update the doc for save_state to mention it will maintain the precision mode thr model is currently in

done

@pacman100 pacman100 merged commit 0768905 into huggingface:main Aug 21, 2023
24 checks passed
@muellerzr muellerzr mentioned this pull request Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@muellerzr muellerzr muellerzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

save_state causes CUDA allocations
4 participants
@pacman100 @HuggingFaceDocBuilderDev @muellerzr @sgugger