Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable power users to bypass device_map="auto" training block #1881

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

muellerzr
Copy link
Collaborator

@muellerzr muellerzr commented Aug 23, 2023

This PR fulfills #1368 (comment) by letting users set ACCELERATE_BYPASS_DEVICE_MAP="true" as an environmental variable so that if users wish to try an experimental approach at TP as described in the issue thread, they can.

@muellerzr
Copy link
Collaborator Author

cc @maxidl :)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 23, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Just one little nit.

src/accelerate/accelerator.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! LGTM with Marc's comment on the name (agreed his is better)

@muellerzr muellerzr merged commit acad5ba into main Aug 24, 2023
26 checks passed
@muellerzr muellerzr deleted the enable-device-map-greedy branch August 24, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants