Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update import of deepspeed integration from transformers #1894

Merged
merged 1 commit into from
Aug 28, 2023
Merged

update import of deepspeed integration from transformers #1894

merged 1 commit into from
Aug 28, 2023

Conversation

pacman100
Copy link
Contributor

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 28, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@pacman100 pacman100 changed the title Update dataclasses.py update import of deepspeed integration from transformers Aug 28, 2023
BenjaminBossan
BenjaminBossan approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the update.

@pacman100 pacman100 merged commit 1ace672 into huggingface:main Aug 28, 2023
24 checks passed
muellerzr
muellerzr reviewed Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, though I think we should have an import check for the transformers version here, otherwise we're going to break on our pypi tests for a while. And deprecate the import across a few transformers versions?

@muellerzr muellerzr mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr left review comments

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pacman100 @HuggingFaceDocBuilderDev @BenjaminBossan @muellerzr